fix(ui): keep tag filter state consistent on tag delete/reapply (#86, #91) #121

Merged

ValleyGeek merged 2 commits from 0.1.40/issue-86-91-tag-filter-fixes into main

2026-06-22 01:22:34 +00:00

Claude commented

2026-06-22 00:33:54 +00:00

Member

Summary

#91 — deleting a tag that was part of the active grid filter only updated the dropdown's own display state, never filter_proxy's active-tag set, so the grid kept filtering by a tag that no longer existed and just looked stuck/empty. _on_delete_tag_from_panel() now removes the deleted tag from the filter's active set too; an empty resulting set is already treated as "no tag filter" by ImageFilterProxy, so deleting the only active tag correctly stops filtering.
#86 — "Untagged Only" was only cleared by the normal click-to-filter path (_move_tag()); the right-click "make this the only active filter" path (_set_exclusive_active) skipped that clear, so combining it with a stale Untagged Only checkbox left the grid showing nothing. Factored the clear into a shared _clear_untagged_only() used by both paths.

Test plan

ruff check / ruff format --check
pytest
PR-prep version bump 0.1.40 → 0.1.41

Refs #86, #91.

Stacked on #120 — part of the 11-PR sequential chain into main.

## Summary - **#91** — deleting a tag that was part of the active grid filter only updated the dropdown's own display state, never `filter_proxy`'s active-tag set, so the grid kept filtering by a tag that no longer existed and just looked stuck/empty. `_on_delete_tag_from_panel()` now removes the deleted tag from the filter's active set too; an empty resulting set is already treated as "no tag filter" by `ImageFilterProxy`, so deleting the only active tag correctly stops filtering. - **#86** — "Untagged Only" was only cleared by the normal click-to-filter path (`_move_tag()`); the right-click "make this the only active filter" path (`_set_exclusive_active`) skipped that clear, so combining it with a stale Untagged Only checkbox left the grid showing nothing. Factored the clear into a shared `_clear_untagged_only()` used by both paths. ## Test plan - [x] `ruff check` / `ruff format --check` - [x] `pytest` - [x] PR-prep version bump 0.1.40 → 0.1.41 Refs #86, #91. Stacked on #120 — part of the 11-PR sequential chain into `main`.

Claude added 2 commits

2026-06-22 00:33:55 +00:00

fix(ui): keep tag filter consistent when its tag is deleted or reapplied f8bef0a8a5

#91: deleting a tag that was part of the active filter only updated the
TagFilterDropdown popup's own display state (set_tag_catalog() already drops
tags that no longer exist) — it never told filter_proxy, which holds the
actual active-tag set driving the grid. The grid kept filtering by a tag name
nothing has anymore, so it just looked stuck/empty. _on_delete_tag_from_panel()
now removes the deleted tag from filter_proxy's active set too; an empty
resulting set is already treated as "no tag filter" by ImageFilterProxy, so
deleting the only active tag correctly stops filtering.

#86: "Untagged Only" was only cleared by _move_tag() (the normal click path).
The right-click "make this the only active filter" path (_set_exclusive_active)
applies a tag filter too but skipped that clear, so combining it with a stale
Untagged Only checkbox left the grid showing nothing. Factored the clear into
a shared _clear_untagged_only() used by both.

docs: PR-prep for issues 86 and 91 - bump to 0.1.41

CI / lint (push) Successful in 17s

Details

CI / test (push) Successful in 2m9s

Details

CI / appimage (push) Successful in 8m12s

Details

CI / build-appimage (push) Successful in 0s

Details

CI / windows-exe (push) Successful in 9m53s

Details

CI / build-windows-exe (push) Successful in 0s