ai-collab/bulk-image-organizer

Fork 0

[Enhancement]: Clear Untagged Only When Changing Tag Filter #86

New issue

Closed

opened 2026-06-14 19:11:05 +00:00 by ValleyGeek · 3 comments

ValleyGeek commented

2026-06-14 19:11:05 +00:00

Owner

Affected area

Tag Filter

Current behavior

When Untagged Only is checked and a new tag filter is applied no images are displayed

Desired improvement

Clear the Untagged Only checkbox any time a tag filter is applied.

References

No response

### Affected area Tag Filter ### Current behavior When `Untagged Only` is checked and a new tag filter is applied no images are displayed ### Desired improvement Clear the `Untagged Only` checkbox any time a tag filter is applied. ### References _No response_

ValleyGeek added the

Kind/Enhancement

Priority

Low

labels

2026-06-14 19:11:05 +00:00

Claude referenced this issue from a commit

2026-06-20 11:32:25 +00:00

fix(ui): keep tag filter consistent when its tag is deleted or reapplied

Claude commented

2026-06-20 11:33:04 +00:00

Member

Fixed on branch 0.1.40/issue-86-91-tag-filter-fixes (queued for PR to main, not yet opened).

TagFilterDropdown._move_tag() (the normal click-to-filter path) already cleared "Untagged Only" when a tag filter was applied. The right-click "make this the only active filter" path (_set_exclusive_active) applies a tag filter too but skipped that clear, so combining it with a stale Untagged Only checkbox left the grid showing nothing. Factored the clear into a shared _clear_untagged_only() helper used by both paths.

Added regression tests in tests/test_tag_filter_enhancements.py for both paths.

Closing — fix implemented and tested.

Fixed on branch `0.1.40/issue-86-91-tag-filter-fixes` (queued for PR to `main`, not yet opened). `TagFilterDropdown._move_tag()` (the normal click-to-filter path) already cleared "Untagged Only" when a tag filter was applied. The right-click "make this the only active filter" path (`_set_exclusive_active`) applies a tag filter too but skipped that clear, so combining it with a stale Untagged Only checkbox left the grid showing nothing. Factored the clear into a shared `_clear_untagged_only()` helper used by both paths. Added regression tests in `tests/test_tag_filter_enhancements.py` for both paths. Closing — fix implemented and tested.

Claude closed this issue

2026-06-20 11:33:46 +00:00

ValleyGeek commented

2026-06-20 15:58:01 +00:00

Author

Owner

When a tag filter is active and 'Untagged Only' is checked, the filters update correctly. The tag element in the Tag Filter menu is cleared from the 'Active' heading but not redrawn in the 'Available' menu until the tag filter dropdown is closed and re-opened.

When a tag filter is active and 'Untagged Only' is checked, the filters update correctly. The tag element in the `Tag Filter` menu is cleared from the 'Active' heading but not redrawn in the 'Available' menu until the tag filter dropdown is closed and re-opened.

ValleyGeek reopened this issue

2026-06-20 15:58:01 +00:00

Claude referenced this issue from a commit

2026-06-20 17:06:00 +00:00

fix: address re-tested feedback on #111, #86, #64; polish #89 (Copied feedback)

Claude commented

2026-06-20 17:06:41 +00:00

Member

Good catch, and thanks for the precise repro — found the actual cause this time. Fixed on branch 0.1.47/issue-111-86-64-89-feedback-fixes.

The first round of this fix only patched the tag-click paths (_move_tag / _set_exclusive_active). The path you exercised — checking Untagged Only while a tag filter is active — goes through a separate handler, TagFilterDropdown._on_untagged_only(), which cleared self._active but never moved those tags back into self._available. So they vanished from the dropdown entirely until you closed and reopened it, which rebuilds the lists from scratch and papers over the gap. Fixed to mirror the same move-back behavior the other two paths already had. Added a regression test (test_tag_filter_untagged_only_moves_cleared_active_tag_to_available) that asserts the tag reappears in Available immediately, without needing to reopen the dropdown.

Closing again — let me know if it still doesn't redraw correctly for your case.

Good catch, and thanks for the precise repro — found the actual cause this time. Fixed on branch `0.1.47/issue-111-86-64-89-feedback-fixes`. The first round of this fix only patched the tag-click paths (`_move_tag` / `_set_exclusive_active`). The path you exercised — checking **Untagged Only** while a tag filter is active — goes through a separate handler, `TagFilterDropdown._on_untagged_only()`, which cleared `self._active` but never moved those tags back into `self._available`. So they vanished from the dropdown entirely until you closed and reopened it, which rebuilds the lists from scratch and papers over the gap. Fixed to mirror the same move-back behavior the other two paths already had. Added a regression test (`test_tag_filter_untagged_only_moves_cleared_active_tag_to_available`) that asserts the tag reappears in Available immediately, without needing to reopen the dropdown. Closing again — let me know if it still doesn't redraw correctly for your case.

Claude closed this issue

2026-06-20 17:06:52 +00:00

Claude referenced this issue

2026-06-22 00:33:54 +00:00

fix(ui): keep tag filter state consistent on tag delete/reapply (#86, #91) #121

Claude referenced this issue from a commit

2026-06-22 00:38:18 +00:00

docs: PR-prep for the 0.1.x feature-tranche close-out - bump to 0.2.0

Claude referenced this issue

2026-06-22 00:38:38 +00:00

Feedback-fix rounds for #111, #86, #64, #89, #109, #57, #58, #21 — bump to 0.2.0 #129

Claude referenced this issue from a commit