[Enhancement]: Deleting Active Tag Removes from Filter #91

New issue

Closed

opened 2026-06-14 22:02:21 +00:00 by ValleyGeek · 1 comment

ValleyGeek commented

2026-06-14 22:02:21 +00:00

Owner

Affected area

Tag Filter and Tag Name Toolbox

Current behavior

If a tag is active and you delete it the tag filter doesn't remove it

Desired improvement

When a tag is deleted, remove it from the active filter list. If it's the only active tag then stop filtering

References

No response

### Affected area Tag Filter and Tag Name Toolbox ### Current behavior If a tag is active and you delete it the tag filter doesn't remove it ### Desired improvement When a tag is deleted, remove it from the active filter list. If it's the only active tag then stop filtering ### References _No response_

ValleyGeek added the

Priority

Low

Kind/Enhancement

labels

2026-06-14 22:02:21 +00:00

Claude referenced this issue from a commit

2026-06-20 11:32:25 +00:00

fix(ui): keep tag filter consistent when its tag is deleted or reapplied

Claude commented

2026-06-20 11:32:48 +00:00

Member

Fixed on branch 0.1.40/issue-86-91-tag-filter-fixes (queued for PR to main, not yet opened).

Root cause: TagFilterDropdown.set_tag_catalog() already drops a deleted tag from its own internal active-tag list when the panel refreshes, but that's just the popup's display state — the actual active-tag set driving the grid lives separately on ImageFilterProxy, and nothing told it the tag was gone. The grid kept filtering by a tag name no image has anymore, which just looked like the filter was stuck.

_on_delete_tag_from_panel() now also removes the deleted tag from filter_proxy's active set. An empty resulting set is already treated by ImageFilterProxy as "no tag filter applied," so deleting the only active tag correctly stops filtering entirely, per the issue description.

Added regression tests in tests/test_pr9_tags.py covering both the multi-tag and only-active-tag cases.

Closing — fix implemented and tested.

Fixed on branch `0.1.40/issue-86-91-tag-filter-fixes` (queued for PR to `main`, not yet opened). Root cause: `TagFilterDropdown.set_tag_catalog()` already drops a deleted tag from its own internal active-tag list when the panel refreshes, but that's just the popup's display state — the actual active-tag set driving the grid lives separately on `ImageFilterProxy`, and nothing told it the tag was gone. The grid kept filtering by a tag name no image has anymore, which just looked like the filter was stuck. `_on_delete_tag_from_panel()` now also removes the deleted tag from `filter_proxy`'s active set. An empty resulting set is already treated by `ImageFilterProxy` as "no tag filter applied," so deleting the only active tag correctly stops filtering entirely, per the issue description. Added regression tests in `tests/test_pr9_tags.py` covering both the multi-tag and only-active-tag cases. Closing — fix implemented and tested.

Claude closed this issue

2026-06-20 11:33:30 +00:00

Claude referenced this issue

2026-06-22 00:33:54 +00:00

fix(ui): keep tag filter state consistent on tag delete/reapply (#86, #91) #121

Claude referenced this issue from a commit

2026-06-22 00:38:18 +00:00

docs: PR-prep for the 0.1.x feature-tranche close-out - bump to 0.2.0

Claude referenced this issue from a commit

2026-06-22 00:53:23 +00:00

fix(ui): keep tag filter consistent when its tag is deleted or reapplied

Claude referenced this issue from a commit