ai-collab/bulk-image-organizer
ai-collab/bulk-image-organizer
3
0
Fork 0
Code Issues 2 Pull requests Projects Releases 75 Packages Wiki Activity Actions

Fix filmstrip truncating small duplicate groups (fixes #53) #73

Merged
ValleyGeek merged 2 commits from 0.1.27/issue-53-filmstrip-dupe into main 2026-06-13 05:07:52 +00:00
Conversation 0 Commits 2 Files changed 4 +24 -5
Grok commented 2026-06-13 05:06:53 +00:00
Member
Copy link

Summary

Fixes #53 — in the Duplicates workbench Single viewer, the filmstrip now shows every image in the active duplicate group when all thumbnails fit at the current filmstrip size. Groups with 3–6 images are no longer truncated.

Root cause

filmstrip_visible_window() applied sliding-window centering and even→odd visible-count reduction even when the entire session fit in the strip. For small duplicate groups (the viewer session is only the current group), that logic hid edge images—especially for even-sized groups of 4 or 6.

Fix

  • When visible >= total, return the full [0, total) window.
  • Apply even→odd reduction only for partial windows (visible < total).
  • Compute max slot capacity using the 15 px inter-thumb gap so fit math matches paint layout.

Testing

  • test_filmstrip_visible_window_shows_entire_small_group_when_it_fits (new regression test)
  • ruff check / ruff format --check
  • pytest tests/test_pr8_viewer.py (44 passed)
  • ./scripts/check-version-bump.sh

Release

  • Version 0.1.28
  • CHANGELOG updated
## Summary Fixes #53 — in the Duplicates workbench Single viewer, the filmstrip now shows every image in the active duplicate group when all thumbnails fit at the current filmstrip size. Groups with 3–6 images are no longer truncated. ## Root cause `filmstrip_visible_window()` applied sliding-window centering and even→odd visible-count reduction even when the entire session fit in the strip. For small duplicate groups (the viewer session is only the current group), that logic hid edge images—especially for even-sized groups of 4 or 6. ## Fix - When `visible >= total`, return the full `[0, total)` window. - Apply even→odd reduction only for partial windows (`visible < total`). - Compute max slot capacity using the 15 px inter-thumb gap so fit math matches paint layout. ## Testing - `test_filmstrip_visible_window_shows_entire_small_group_when_it_fits` (new regression test) - `ruff check` / `ruff format --check` - `pytest tests/test_pr8_viewer.py` (44 passed) - `./scripts/check-version-bump.sh` ## Release - Version **0.1.28** - CHANGELOG updated
fix: show full dupe group in filmstrip when all thumbnails fit (#53)
Some checks failed
Windows Release / prune-dev-release (push) Has been skipped
Details
Windows Release / build-release (push) Successful in 8m18s
Details
CI / lint (pull_request) Has been cancelled
Details
CI / test (pull_request) Has been cancelled
Details
CI / nuitka-smoke (pull_request) Has been cancelled
Details
c771f572fe 
filmstrip_visible_window no longer drops even-sized duplicate groups when
every image fits in the strip. Slot capacity accounts for the 15 px gap
between thumbnails, and the window spans the entire session instead of
centering with an even visible count that hid edge images.
docs: PR-prep for issue 53 (filmstrip dupe group fix)
All checks were successful
CI / lint (pull_request) Successful in 6s
Details
CI / test (pull_request) Successful in 1m25s
Details
Windows Release / build-release (push) Successful in 8m39s
Details
Windows Release / prune-dev-release (push) Has been skipped
Details
CI / nuitka-smoke (pull_request) Successful in 1m2s
Details
ee60bf1fb2 
Bump to 0.1.28 and document the filmstrip visibility fix in CHANGELOG.
ValleyGeek deleted branch 0.1.27/issue-53-filmstrip-dupe 2026-06-13 05:07:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind/Bug
Something isn't working as expected

  
Kind/Feature
New capability or user-requested feature

  
Priority/High
High priority

  
Priority/Medium
Medium priority

  
Reviewed/Confirmed
Bug or feature report confirmed valid

  
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Kind/Bug
Kind/Feature
Priority/High
Priority/Medium
Reviewed/Confirmed
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ai-collab/bulk-image-organizer!73
No description provided.