[Bug]: Filmstrip only showing three Images in Dupe Workbench #53

New issue

Closed

opened 2026-06-12 06:23:23 +00:00 by ValleyGeek · 2 comments

ValleyGeek commented

2026-06-12 06:23:23 +00:00

Owner

App version

0.1.21 - 0.1.25

Platform

Both

Steps to reproduce

Open a directory with a duplicate set greater than three images
Enter the duplicates workbench and find duplicates to create a group with more than three images
Select a duplicate set with more than three images
Open the image viewer for the set of images and view the filmstrip

Expected behavior

All images from the set that will fit in the filmstrip area at the given filmstrip thumbnail size level are visible

Actual behavior

7 or more images seem to work as expected. 3-6 images have some set of images truncated preventing the group from showing.

Additional context

### App version 0.1.21 - 0.1.25 ### Platform Both ### Steps to reproduce 1. Open a directory with a duplicate set greater than three images 2. Enter the duplicates workbench and find duplicates to create a group with more than three images 3. Select a duplicate set with more than three images 4. Open the image viewer for the set of images and view the filmstrip ### Expected behavior All images from the set that will fit in the filmstrip area at the given filmstrip thumbnail size level are visible ### Actual behavior 7 or more images seem to work as expected. 3-6 images have some set of images truncated preventing the group from showing. ### Additional context

ValleyGeek added the

Kind/Bug

Priority

High

labels

2026-06-12 06:23:23 +00:00

Grok commented

2026-06-13 02:02:18 +00:00

Member

Fix implemented on branch 0.1.27/issue-53-filmstrip-dupe.

Root cause: filmstrip_visible_window() applied odd-count centering even when every image in the session fit in the strip. For duplicate groups with 4 or 6 images (and some 5-image cases at narrower widths), that centering window started at index 0 but ended before the last group member.

Fix:

When visible >= total, return the full [0, total) window.
Apply the even→odd visible reduction only for partial windows (visible < total).
Compute max slot capacity using the 15 px inter-thumb gap so fit tests match paint layout.

Regression test added in tests/test_pr8_viewer.py.

Fix implemented on branch `0.1.27/issue-53-filmstrip-dupe`. **Root cause:** `filmstrip_visible_window()` applied odd-count centering even when every image in the session fit in the strip. For duplicate groups with 4 or 6 images (and some 5-image cases at narrower widths), that centering window started at index 0 but ended before the last group member. **Fix:** 1. When `visible >= total`, return the full `[0, total)` window. 2. Apply the even→odd visible reduction only for partial windows (`visible < total`). 3. Compute max slot capacity using the 15 px inter-thumb gap so fit tests match paint layout. Regression test added in `tests/test_pr8_viewer.py`.

Grok referenced this issue from a commit

2026-06-13 02:02:20 +00:00

fix: show full dupe group in filmstrip when all thumbnails fit (#53)

Grok closed this issue

2026-06-13 05:06:53 +00:00

Grok commented

2026-06-13 05:06:53 +00:00

Member

Verified by reporter. Closed with PR to main (branch 0.1.27/issue-53-filmstrip-dupe, release 0.1.28).

Verified by reporter. Closed with PR to `main` (branch `0.1.27/issue-53-filmstrip-dupe`, release **0.1.28**).

Grok referenced this issue from a pull request that will close it,

2026-06-13 05:06:53 +00:00