fix(ui): tag filter toggle close on Windows and content-fit height (#25) #33

Merged

ValleyGeek merged 5 commits from 0.1.2/issue-25-tag-filter-close into main

2026-06-10 01:30:58 +00:00

Grok commented

2026-06-10 01:18:31 +00:00

Member

Summary

Fixes #25 — the Tag Filter menu no longer reopens when the toolbar button is clicked a second time on Windows. Also sizes the popup to its tag list and fixed controls, capped at 500px.

Changes

Windows toggle close: Detect when Qt.Popup auto-dismisses from an anchor-button click and ignore the follow-up open request on the next button click.
Content-fit height: Popup height follows tag list + chrome (search, checkboxes, Clear Filter), max 500px; scroll only when needed.
Measurement fix: Use layout sizeHint() on a deferred update so fixed-height tag buttons (28px) are not undercounted by widget sizeHint() (23px).

Version

Bumps VERSION from 0.1.2 → 0.1.7.

Tests

test_tag_filter_anchor_click_stays_closed_after_popup_auto_dismiss
test_tag_filter_popup_height_fits_content_up_to_max
tests/test_pr7_shell.py (13 tests)
smoke-ui-exit.sh

## Summary Fixes #25 — the Tag Filter menu no longer reopens when the toolbar button is clicked a second time on Windows. Also sizes the popup to its tag list and fixed controls, capped at 500px. ## Changes - **Windows toggle close:** Detect when `Qt.Popup` auto-dismisses from an anchor-button click and ignore the follow-up open request on the next button click. - **Content-fit height:** Popup height follows tag list + chrome (search, checkboxes, Clear Filter), max 500px; scroll only when needed. - **Measurement fix:** Use layout `sizeHint()` on a deferred update so fixed-height tag buttons (28px) are not undercounted by widget `sizeHint()` (23px). ## Version Bumps `VERSION` from 0.1.2 → **0.1.7**. ## Tests - `test_tag_filter_anchor_click_stays_closed_after_popup_auto_dismiss` - `test_tag_filter_popup_height_fits_content_up_to_max` - `tests/test_pr7_shell.py` (13 tests) - `smoke-ui-exit.sh`

Grok added 5 commits

2026-06-10 01:18:31 +00:00

fix(ui): tag filter closes on second button press on Windows (#25 ) 3a5723193b

On Windows, Qt.Popup auto-dismisses before the Tag Filter button click
handler runs, so the popup briefly closed and immediately reopened.
Detect anchor-button dismissals and ignore the follow-up open request.

Includes a regression test that simulates the Windows event ordering.
Bumps VERSION to 0.1.3.

ui: increase tag filter menu height to 1260px (#25 ) 3d370bb78e

Triple the prior 420px cap so more tags are visible in the
scrollable list. Bumps VERSION to 0.1.4.

ui: set tag filter menu height to 500px (#25 ) ae4c6fe6e1

Bumps VERSION to 0.1.5.

ui: size tag filter menu to content with 500px cap (#25 ) e59c0aa90c

Compute popup height from the tag list and fixed controls instead of
using a fixed 500px panel. Scroll the tag list when content exceeds
the maximum. Bumps VERSION to 0.1.6.

fix(ui): measure tag filter height from layout size hints (#25 )

CI / lint (pull_request) Successful in 14s

Details

CI / test (pull_request) Successful in 3m15s

Details

CI / nuitka-smoke (pull_request) Successful in 18m18s

Details

eba637451a

Tag swatch buttons report a 23px size hint but render at 28px, which
left the scroll area five pixels short and showed a scrollbar early.
Use layout sizeHint() after a deferred update and compute chrome from
the fixed control rows without zeroing the scroll area height.
Bumps VERSION to 0.1.7.