[Bug]: Tag Filter Menu Doesn't Close on Button Press #25
Labels
No labels
Kind/Bug
Kind/Feature
Priority/High
Priority/Medium
Reviewed/Confirmed
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
ai-collab/bulk-image-organizer#25
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
App version
0.1.1
Platform
Windows
Steps to reproduce
tag filterbutton to open the tag filter menutag filermenu is open, click thetag filterbutton a second timeExpected behavior
The tag filter menu should close
Actual behavior
The tag filter menu closes briefly but reopens immediately. The only way to close is to click elsewhere in the application
Additional context
The bug is not present on Linux
Fixed on branch
0.1.2/issue-25-tag-filter-close(VERSION 0.1.3).Root cause: On Windows,
Qt.Popupauto-dismisses when the Tag Filter button is clicked (outside-click handling) before the button'sclickedhandler runs. The handler then sawisVisible() == Falseand reopened the popup.Fix: When the popup is dismissed with the cursor over the anchor button, set
_tag_filter_ignore_next_clickso the subsequent button click closes cleanly instead of reopening. Linux behavior is unchanged.Verification: Regression test
test_tag_filter_anchor_click_stays_closed_after_popup_auto_dismisssimulates the Windows event ordering;smoke-ui-exit.shpasses.Fixed on branch
0.1.2/issue-25-tag-filter-close(VERSION 0.1.3).Root cause: On Windows,
Qt.Popupauto-dismisses when the Tag Filter button is clicked before the buttonclickedhandler runs, so the popup briefly closed and immediately reopened.Fix: When the popup is dismissed with the cursor over the anchor button, ignore the follow-up open request on the next button click.
Verification: Regression test
test_tag_filter_anchor_click_stays_closed_after_popup_auto_dismiss;smoke-ui-exit.shpasses.Resolved in branch
0.1.2/issue-25-tag-filter-close(VERSION 0.1.7), PR to follow.Windows toggle fix: When the Tag Filter button is clicked while the menu is open,
Qt.Popupauto-dismisses before the button handler runs. The handler now ignores the follow-up open request when dismissal came from the anchor button.Height improvements (same branch): Menu height fits tag list + fixed controls, capped at 500px. Layout
sizeHint()is used (deferred one event tick) so fixed-height tag buttons measure correctly and a scrollbar does not appear prematurely.Tests:
test_tag_filter_anchor_click_stays_closed_after_popup_auto_dismiss,test_tag_filter_popup_height_fits_content_up_to_max.