Stop status bar from echoing Sort into Folders' progress dialog (0.9.1) #181

Merged

ValleyGeek merged 2 commits from 0.9.0/status-bar-dialog-dedup into main

2026-08-27 20:23:31 +00:00

Claude commented

2026-08-27 18:30:46 +00:00

Member

Summary

Audited every status dialog that reports progress (NetworkHydrateDialog, NetworkSyncDialog, SubdirTagBuildDialog, SortProgressDialog, SortIntoFoldersDialog) for the main status bar redundantly showing the same message a dialog is already displaying. Only Sort into Folders had the bug: _on_sort_progress wrote the identical message to both SortProgressDialog and the main status bar on every progress tick, and _start_sort_into_folders set an extra one-off status-bar message right as the dialog opened.

The other three dialogs already followed the correct pattern — write to the dialog only while it's shown — established by _sync_workspace_cache_to_share_if_needed's _on_status/_on_progress branching. Sort's progress handler now follows the same pattern, with a defensive fallback to the status bar only in the (currently unreachable) case where the dialog isn't present.

fix(ui) commit: removes the duplicate status-bar writes.
PR-prep commit: bumps VERSION to 0.9.1 (compiled inputs changed) and adds the CHANGELOG section.

Test plan

ruff check . / ruff format --check . — clean
Full pytest -q — 775 passed, 1 skipped
./scripts/check-version-bump.sh — confirms VERSION bumped (0.9.0 → 0.9.1)

https://claude.ai/code/session_01TrNqVfQQpmRfwhoUkKkkiJ

## Summary Audited every status dialog that reports progress (`NetworkHydrateDialog`, `NetworkSyncDialog`, `SubdirTagBuildDialog`, `SortProgressDialog`, `SortIntoFoldersDialog`) for the main status bar redundantly showing the same message a dialog is already displaying. Only **Sort into Folders** had the bug: `_on_sort_progress` wrote the identical message to both `SortProgressDialog` and the main status bar on every progress tick, and `_start_sort_into_folders` set an extra one-off status-bar message right as the dialog opened. The other three dialogs already followed the correct pattern — write to the dialog only while it's shown — established by `_sync_workspace_cache_to_share_if_needed`'s `_on_status`/`_on_progress` branching. Sort's progress handler now follows the same pattern, with a defensive fallback to the status bar only in the (currently unreachable) case where the dialog isn't present. - `fix(ui)` commit: removes the duplicate status-bar writes. - PR-prep commit: bumps `VERSION` to `0.9.1` (compiled inputs changed) and adds the CHANGELOG section. ## Test plan - [x] `ruff check .` / `ruff format --check .` — clean - [x] Full `pytest -q` — 775 passed, 1 skipped - [x] `./scripts/check-version-bump.sh` — confirms `VERSION` bumped (`0.9.0` → `0.9.1`) https://claude.ai/code/session_01TrNqVfQQpmRfwhoUkKkkiJ

Claude added 2 commits

2026-08-27 18:30:46 +00:00

fix(ui): stop the status bar from echoing Sort into Folders' dialog

CI / lint (push) Successful in 16s

Details

CI / test (push) Successful in 3m52s

Details

CI / appimage (push) Successful in 16m35s

Details

CI / build-appimage (push) Successful in 0s

Details

CI / windows-exe (push) Successful in 18m12s

Details

CI / build-windows-exe (push) Successful in 0s

Details

e505b6d348

SortProgressDialog is modal and always shown while a sort is running,
but _on_sort_progress also wrote the same message straight to the
main status bar on every tick, and _start_sort_into_folders set an
extra one-off status-bar message right as the dialog opened. Neither
NetworkHydrateDialog, NetworkSyncDialog, nor SubdirTagBuildDialog had
this problem -- their progress callbacks already write to the dialog
only. Sort's callback now does the same, falling back to the status
bar only in the (currently unreachable) case where the dialog isn't
present.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TrNqVfQQpmRfwhoUkKkkiJ

docs: PR-prep for status-bar dialog dedup fix (0.9.1)

CI / lint (push) Successful in 34s

Details

CI / test (push) Successful in 7m20s

Details

CI / appimage (push) Successful in 22m5s

Details

CI / build-appimage (push) Successful in 0s

Details

CI / windows-exe (push) Successful in 43m2s

Details

CI / build-windows-exe (push) Successful in 0s

Details

daba7ed9b8

Bumps VERSION to the next canonical release (0.9.1) since this branch
touched compiled inputs, and adds the 0.9.1 CHANGELOG section.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TrNqVfQQpmRfwhoUkKkkiJ