Fix crop overlay handle cursors on hover (0.6.1, issue #165) #169

Merged

ValleyGeek merged 2 commits from 0.6.0/issue-165-crop-cursor into main

2026-08-20 21:53:55 +00:00

Grok commented

2026-08-20 21:45:00 +00:00

Member

Fixes #165.

Crop mode left the pointer on the default or open-hand cursor when hovering the selection border, especially after a handle drag and on fitted large images.

Cause

Mouse-up restored ScrollHandDrag, which forces OpenHandCursor while crop was still active.
Hover mouse-move was not consumed, so QGraphicsView could overwrite the viewport cursor.
Handle hit radii were image pixels, so a fitted photo had only a few screen pixels of grab zone (plus a dead zone between the corner circle and inset edge segments).

Change

Keep NoDrag for the whole crop session.
Consume hover/move and set the cursor from hit-testing.
Convert corner/edge radii and solid handle marks to viewport pixels; drop the edge inset; cosmetic border pens.
Overlay graphics ignore mouse events so they do not steal hover.

Version: 0.6.1 (compiled-input patch).

Fixes #165. Crop mode left the pointer on the default or open-hand cursor when hovering the selection border, especially after a handle drag and on fitted large images. **Cause** - Mouse-up restored `ScrollHandDrag`, which forces `OpenHandCursor` while crop was still active. - Hover mouse-move was not consumed, so `QGraphicsView` could overwrite the viewport cursor. - Handle hit radii were image pixels, so a fitted photo had only a few screen pixels of grab zone (plus a dead zone between the corner circle and inset edge segments). **Change** - Keep `NoDrag` for the whole crop session. - Consume hover/move and set the cursor from hit-testing. - Convert corner/edge radii and solid handle marks to viewport pixels; drop the edge inset; cosmetic border pens. - Overlay graphics ignore mouse events so they do not steal hover. **Version:** `0.6.1` (compiled-input patch).

Grok added 2 commits

2026-08-20 21:45:01 +00:00

fix: keep crop handle cursors while hovering the overlay

CI / lint (push) Successful in 9s

Details

CI / test (push) Successful in 2m29s

Details

CI / appimage (push) Successful in 12m34s

Details

CI / build-appimage (push) Successful in 0s

Details

CI / windows-exe (push) Successful in 14m51s

Details

CI / build-windows-exe (push) Successful in 0s

Details

5d8a2a5486

Crop mode no longer restores ScrollHandDrag on mouse-up, so the view cannot
overwrite resize cursors with the open-hand pan pointer. Hover moves are
consumed, hit radii are in viewport pixels, and overlay items ignore mouse
events so the visible border stays interactive at any zoom.

docs: PR-prep for 0.6.1 crop handle cursor fix

CI / lint (push) Successful in 14s

Details

CI / test (push) Successful in 2m52s

Details

CI / appimage (push) Successful in 16m30s

Details

CI / build-appimage (push) Successful in 0s

Details

CI / windows-exe (push) Successful in 18m51s

Details

CI / build-windows-exe (push) Successful in 0s

Details

40bf22ea96

Bump VERSION to 0.6.1 for the compiled crop-overlay cursor fix. Document
viewport-pixel handle hit-testing in the user guide, DESIGN, TECHNICAL_OUTLINE,
and changelog.

Grok added the

Kind/Bug

Priority/Medium

labels

2026-08-20 21:45:26 +00:00