Expand documented-feature test coverage and drop leftover APIs (0.5.0) #161

Merged

ValleyGeek merged 11 commits from 0.4.3/issue-160-test-coverage into main 2026-08-13 06:45:02 +00:00

Conversation 0 Commits 11 Files changed 43 +932 -560

Grok commented 2026-08-13 06:15:02 +00:00

Member

Copy link

Summary

Issue #160. Locks documented product intent in automated tests, aligns leftover code with the user guide, and bumps VERSION to 0.5.0.

Tests

• Sort by Date and Tag Priority
• Search persist / all-options-off / metadata worker cancel
• Visual DupeWorker scan and cancel
• Dupe Grid Hide Deleted, Trash Clear Deleted Flag, Confirm Delete undo-stack
• Settings Image Types, shortcut editor, Tag Filter search/clear
• Crop/mirror toolbar from Grid only
• Replaced no-assert / tautological cases; folded the overlapping dupe-tag filter test

Product alignment

• Viewer and Duplicates Multi load at full resolution by default (no 2048px cap)
• Filters, cleanup, panel exclusion, and sort recognize legacy DUPE-FILE_ / DUPE_ / Dupe_ prefixes
• Removed unused leftover APIs (old Keep Best picker, metadata-only share export, unused scan/path wrappers)

CI

• Linux AppImage job treats release_build_needed.py exit 1 (no build inputs) as a successful skip, matching Windows

The bundled user guide already described this behavior; no USER_GUIDE edits in this PR. compiled-inputs-changed.sh origin/main exits 0 (src/ + VERSION).

Test plan

• ./scripts/check-version-bump.sh origin/main — 0.4.3 → 0.5.0
• Folded dupe-filter test + tests/test_version.py
• Earlier branch runs: ruff + the expanded suite on this branch
• CI lint / pytest / AppImage (this commit changes linux-appimage.yml, so the AppImage job should build)

## Summary Issue #160. Locks documented product intent in automated tests, aligns leftover code with the user guide, and bumps `VERSION` to **0.5.0**. ### Tests - Sort by Date and Tag Priority - Search persist / all-options-off / metadata worker cancel - Visual `DupeWorker` scan and cancel - Dupe Grid Hide Deleted, Trash Clear Deleted Flag, Confirm Delete undo-stack - Settings Image Types, shortcut editor, Tag Filter search/clear - Crop/mirror toolbar from Grid only - Replaced no-assert / tautological cases; folded the overlapping dupe-tag filter test ### Product alignment - Viewer and Duplicates Multi load at full resolution by default (no 2048px cap) - Filters, cleanup, panel exclusion, and sort recognize legacy `DUPE-FILE_` / `DUPE_` / `Dupe_` prefixes - Removed unused leftover APIs (old Keep Best picker, metadata-only share export, unused scan/path wrappers) ### CI - Linux AppImage job treats `release_build_needed.py` exit 1 (no build inputs) as a successful skip, matching Windows The bundled user guide already described this behavior; no USER_GUIDE edits in this PR. `compiled-inputs-changed.sh origin/main` exits 0 (`src/` + `VERSION`). ## Test plan - [x] `./scripts/check-version-bump.sh origin/main` — `0.4.3` → `0.5.0` - [x] Folded dupe-filter test + `tests/test_version.py` - [x] Earlier branch runs: ruff + the expanded suite on this branch - [ ] CI lint / pytest / AppImage (this commit changes `linux-appimage.yml`, so the AppImage job should build)

Grok added 11 commits 2026-08-13 06:15:03 +00:00

test: Cover sort by Date and Tag Priority ... 4e0b2d81b4

Lock the documented sort keys that were implemented but untested, including
Tag Priority ignoring DELETE and duplicate-prefix tags.

test: Cover search persist, options-off, and metadata worker ... e173928d26

Assert documented search intent: all options off matches nothing, term and
options persist across restart, opening a directory clears the term, and the
background metadata worker adds only non-fast hits.

test: Cover visual dupe scan, cancel, and Hide Deleted ... 257294b613

Add visual DupeWorker coverage (V-DUPE tags, no exact hash), cancel during
hash vs assignment (groups found so far are kept), and Dupe Grid Hide Deleted
dropping only fully deleted groups while the right-column list stays intact.

test: Cover trash, image types, shortcuts, and related UI intent ... 5ec5b85bc3

Add regression tests for Clear Deleted Flag (filter-scoped, undoable), Confirm
Delete clearing the undo stack, Image Types prune, thumbnail resolution
regeneration, shortcut editor duplicate-reject and Reset All, Tag Filter
search/clear, and crop/mirror hidden in Duplicates Single.

test: Replace weak suite cases with real assertions ... 2a3e8f0948

Remove no-assert smoke, existence-only, tautological version identity, and
duplicate proxy/help/icon checks. Give Keep criteria and Multi layout exact
winners, assert theme palette/current_theme, rescan Cancel vs Re-scan labels,
closeEvent shutdown, Tag Filter dupe-section toggle, and skip instead of
silent return when git refs are missing.

fix: Align dupe prefixes and viewer loads with the documented product ... f1bcc9984b

Recognize legacy DUPE-FILE_, DUPE_, and Dupe_ tags in filters, cleanup,
and sort/panel classification, matching the user guide. Load viewer and
Dupe Multi images at full resolution by default. Tests now assert those
contracts instead of the narrower F-/V-DUPE-only helpers and the old
2048px downscale default.

refactor: Remove leftover core APIs no longer used by the product ... 6c8692f4df

Drop unused Keep Best helpers, metadata-only share export, unused scan
path helpers, the unused dupe-tag-filter module, and other wrappers that
only tests still called. Retarget those tests onto the live Keep, scan,
import, and tag-filter paths.

chore: Stop tracking the local AppImage venv ... 48318dd5bb

The previous cleanup commit accidentally added .linux-appimage-venv.
Ignore that directory like other virtualenvs.

test: Fold overlapping dupe-tag filter assertions ... dafd069097

Move empty-filter and unmatched-tag checks into the existing
get_dupe_tag_summaries test and drop the retargeted duplicate.

ci: Treat AppImage no-build skip as success ... 2651608e18

release_build_needed.py exits 1 when Linux build inputs did not change.
The detect step ran that under set -e, so the job failed before it could
set needs_build=false. Capture the exit code like the Windows job and
leave the existing Skip notice step as the happy path.

docs: PR-prep for 0.5.0 ... 4b6bc01135

Replace the development VERSION with 0.5.0 and record user-visible
alignment (full-resolution viewer/Multi, legacy dupe prefixes), leftover
API removal, and the AppImage skip-success CI fix.

Grok referenced this pull request 2026-08-13 06:15:10 +00:00

[Testing]: Expand automated coverage for documented product features #160

ValleyGeek merged commit 758000a28f into main 2026-08-13 06:45:02 +00:00

ValleyGeek deleted branch 0.4.3/issue-160-test-coverage 2026-08-13 06:45:03 +00:00

ValleyGeek referenced this pull request from a commit 2026-08-13 06:45:05 +00:00

Expand documented-feature test coverage and drop leftover APIs (0.5.0) (#161)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Kind/Bug

Something isn't working as expected

  

Kind/Feature

New capability or user-requested feature

  

Priority/High

High priority

  

Priority/Medium

Medium priority

  

Reviewed/Confirmed

Bug or feature report confirmed valid

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Kind/Bug

Kind/Feature

Priority/High

Priority/Medium

Reviewed/Confirmed

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

ai-collab/bulk-image-organizer!161

No description provided.