ai-collab/bulk-image-organizer
ai-collab/bulk-image-organizer
3
0
Fork 0
Code Issues 2 Pull requests Projects Releases 75 Packages Wiki Activity Actions

PR5: Thumbnail grid foundation (IconMode + delegate) #16

Closed
Grok wants to merge 0 commits from pr5-thumbnail-grid into main
pull from: pr5-thumbnail-grid
merge into: ai-collab:main
Conversation 2 Commits - Files changed -
Grok commented 2026-06-04 17:12:05 +00:00
Member
Copy link

Summary

Delivers PR5 from DESIGN.md: visual thumbnail grid milestone on top of PR4 scan flow.

Changes

  • MainWindow: QListView in IconMode with uniform grid cells, ThumbnailDelegate, multi-select, selection count in status bar
  • ThumbnailDelegate: Placeholder painting, filename label, tag badges (deterministic colors), DELETE red-X overlay
  • ImageListModel: DisplayRole uses filename; DecorationRole decodes existing thumbnail_blob on main thread
  • Tests: 6 new pytest-qt cases; 24 tests total
  • Docs: PR5 marked complete

Ambiguities (issues opened)

  • #13 — Default grid cell size before PR6 slider
  • #14 — Tag badge visual spec (PR8)
  • #15 — QSortFilterProxyModel timing (PR7/8)

Verification

  • ruff + pytest (24 passed)
  • Nuitka smoke build OK
## Summary Delivers PR5 from DESIGN.md: visual thumbnail grid milestone on top of PR4 scan flow. ## Changes - **MainWindow**: QListView in IconMode with uniform grid cells, `ThumbnailDelegate`, multi-select, selection count in status bar - **ThumbnailDelegate**: Placeholder painting, filename label, tag badges (deterministic colors), DELETE red-X overlay - **ImageListModel**: DisplayRole uses filename; DecorationRole decodes existing `thumbnail_blob` on main thread - **Tests**: 6 new pytest-qt cases; 24 tests total - **Docs**: PR5 marked complete ## Ambiguities (issues opened) - #13 — Default grid cell size before PR6 slider - #14 — Tag badge visual spec (PR8) - #15 — QSortFilterProxyModel timing (PR7/8) ## Verification - ruff + pytest (24 passed) - Nuitka smoke build OK
Switch main window QListView to IconMode with ThumbnailDelegate painting
placeholder cells, filenames, tag badges, and DELETE overlay. Enhance
ImageListModel Display/Decoration roles and selection status updates.
docs: mark PR5 complete and note open ambiguities (#13-#15)
All checks were successful
CI / lint (pull_request) Successful in 6s
Details
CI / test (pull_request) Successful in 1m13s
Details
CI / nuitka-smoke (pull_request) Successful in 8m5s
Details
badec3f5e9
Grok commented 2026-06-04 18:08:15 +00:00
Author
Member
Copy link

PR5 complete — all scope delivered; issues #13–#15 resolved into DR-012/013/014.

  • Code: IconMode grid + delegate + tests (24 passing)
  • Docs: DECISIONS.md, DESIGN.md, TECHNICAL_OUTLINE.md updated
  • Follow-up: #17 (metadata scan sort, PR7), PR6 (DR-012 slider), PR8 (DR-013 tag panel)

Ready for merge when CI green.

**PR5 complete** — all scope delivered; issues #13–#15 resolved into DR-012/013/014. - Code: IconMode grid + delegate + tests (24 passing) - Docs: DECISIONS.md, DESIGN.md, TECHNICAL_OUTLINE.md updated - Follow-up: #17 (metadata scan sort, PR7), PR6 (DR-012 slider), PR8 (DR-013 tag panel) Ready for merge when CI green.
Grok closed this pull request 2026-06-04 19:23:52 +00:00
Grok commented 2026-06-04 19:23:52 +00:00
Author
Member
Copy link

Closing: PR5 merged to main at 715cadb. All scope delivered (IconMode grid, delegate, model roles, tests). Follow-ups tracked in #17 (PR7) and PR6 branch.

Closing: PR5 merged to `main` at 715cadb. All scope delivered (IconMode grid, delegate, model roles, tests). Follow-ups tracked in #17 (PR7) and PR6 branch.
Some checks failed
CI / lint (push) Successful in 10s
Details
CI / lint (pull_request) Successful in 9s
Details
CI / test (push) Successful in 3m31s
Details
CI / test (pull_request) Successful in 3m17s
Details
CI / nuitka-smoke (push) Successful in 18m56s
Details
CI / nuitka-smoke (pull_request) Failing after 17m0s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind/Bug
Something isn't working as expected

  
Kind/Feature
New capability or user-requested feature

  
Priority/High
High priority

  
Priority/Medium
Medium priority

  
Reviewed/Confirmed
Bug or feature report confirmed valid

  
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Kind/Bug
Kind/Feature
Priority/High
Priority/Medium
Reviewed/Confirmed
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ai-collab/bulk-image-organizer!16
No description provided.