ai-collab/bulk-image-organizer
ai-collab/bulk-image-organizer
3
0
Fork 0
Code Issues 2 Pull requests Projects Releases 75 Packages Wiki Activity Actions

Add send-to-trash option for file-duplicate bulk actions (issue #146) #148

Merged
ValleyGeek merged 3 commits from 0.3.5/issue-146-bulk-dupe-trash into main 2026-07-08 21:46:20 +00:00
Conversation 0 Commits 3 Files changed 8 +285 -10
Grok commented 2026-07-08 21:42:37 +00:00
Member
Copy link

Summary

Closes #146.

Adds an optional Send duplicates to system trash checkbox to the File Duplicate Bulk Actions dialog. When enabled (the default), duplicate losers are sent to the platform recycle bin via the existing DeleteWorker path — the same behavior as Trash workbench Confirm Delete. When unchecked, behavior is unchanged: losers receive the DELETE tag only (undoable).

A new Settings → Duplicates toggle persists the dialog default (bulk_dupe_send_to_trash_default).

Version

Bumps to 0.3.6 (PR-prep commit).

Testing

  • pytest tests/test_bulk_dupe_trash.py (6 tests)
  • ruff check / ruff format --check on src and tests
  • ./scripts/check-version-bump.sh origin/main

Threading notes

Trash path reuses existing DeleteWorker (IO + plain-data signals only; no QWidget access in workers).

## Summary Closes #146. Adds an optional **Send duplicates to system trash** checkbox to the File Duplicate Bulk Actions dialog. When enabled (the default), duplicate losers are sent to the platform recycle bin via the existing `DeleteWorker` path — the same behavior as Trash workbench **Confirm Delete**. When unchecked, behavior is unchanged: losers receive the `DELETE` tag only (undoable). A new **Settings → Duplicates** toggle persists the dialog default (`bulk_dupe_send_to_trash_default`). ## Version Bumps to **0.3.6** (PR-prep commit). ## Testing - `pytest tests/test_bulk_dupe_trash.py` (6 tests) - `ruff check` / `ruff format --check` on `src` and `tests` - `./scripts/check-version-bump.sh origin/main` ## Threading notes Trash path reuses existing `DeleteWorker` (IO + plain-data signals only; no QWidget access in workers).
Adds a checkbox to the File Duplicate Bulk Actions dialog (enabled by
default via a new Settings preference) that sends duplicate losers to the
platform trash through DeleteWorker instead of only marking them DELETE.
test: cover bulk dupe send-to-trash dialog, settings, and flow (issue #146)
All checks were successful
CI / lint (push) Successful in 8s
Details
CI / test (push) Successful in 14m45s
Details
CI / appimage (push) Successful in 9m2s
Details
CI / build-appimage (push) Successful in 0s
Details
CI / windows-exe (push) Successful in 10m1s
Details
CI / build-windows-exe (push) Successful in 0s
Details
aa11ee07e6
docs: PR-prep for issue 146 — bump to 0.3.6
All checks were successful
CI / lint (push) Successful in 12s
Details
CI / test (push) Successful in 2m23s
Details
CI / windows-exe (push) Successful in 12m33s
Details
CI / build-windows-exe (push) Successful in 0s
Details
CI / appimage (push) Successful in 17m8s
Details
CI / build-appimage (push) Successful in 0s
Details
06a98e3193 
Updates USER_GUIDE and CHANGELOG for bulk dupe send-to-trash; replaces
dev VERSION with release 0.3.6.
ValleyGeek deleted branch 0.3.5/issue-146-bulk-dupe-trash 2026-07-08 21:46:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind/Bug
Something isn't working as expected

  
Kind/Feature
New capability or user-requested feature

  
Priority/High
High priority

  
Priority/Medium
Medium priority

  
Reviewed/Confirmed
Bug or feature report confirmed valid

  
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Kind/Bug
Kind/Feature
Priority/High
Priority/Medium
Reviewed/Confirmed
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ai-collab/bulk-image-organizer!148
No description provided.