fix(scan): show finalizing status during post-scan cleanup (#114) #135

Merged

ValleyGeek merged 2 commits from 0.2.2/issue-114-soft-lock-after-scan into main 2026-06-24 04:29:56 +00:00

Conversation 0 Commits 2 Files changed 4 +19 -3

Claude commented 2026-06-24 04:26:36 +00:00

Member

Copy link

Summary

• The scan progress bar froze with no feedback between the "Indexing" phase completing and "Scan Complete" appearing: _on_deep_finished runs several synchronous main-thread steps (recent-dir bookkeeping, dupe-tag-singleton pruning, optional network-share cache sync) before updating the status label, and none of it emitted progress.
• Show a "Finalizing scan..." status message with a busy progress indicator as soon as the scan worker's finished signal fires, before this cleanup runs.
• Route the network-share cache sync through the existing progress-UI path (already used by closeEvent) instead of running it silently.
• Bumped to 0.2.3 (patch) and updated CHANGELOG.md / resources/help/USER_GUIDE.md.

Closes #114.

Threading notes

No worker/signal changes — this only adjusts what the main thread does with state it already owns (status_label, progress_bar) at a point where it was already executing synchronously. No QWidget/model access was added to a worker thread.

Test plan

• ruff check / ruff format --check on src, tests, scripts
• pytest — 540 passed, 1 skipped
• ./scripts/check-version-bump.sh — passes (0.2.2 → 0.2.3)
• QT_QPA_PLATFORM=offscreen ./scripts/smoke-ui-exit.sh — clean teardown, no Qt shutdown errors
• pip install -e . in the active venv — scripts/get-version.py --canonical resolves to 0.2.3

## Summary - The scan progress bar froze with no feedback between the "Indexing" phase completing and "Scan Complete" appearing: `_on_deep_finished` runs several synchronous main-thread steps (recent-dir bookkeeping, dupe-tag-singleton pruning, optional network-share cache sync) before updating the status label, and none of it emitted progress. - Show a "Finalizing scan..." status message with a busy progress indicator as soon as the scan worker's `finished` signal fires, before this cleanup runs. - Route the network-share cache sync through the existing progress-UI path (already used by `closeEvent`) instead of running it silently. - Bumped to `0.2.3` (patch) and updated `CHANGELOG.md` / `resources/help/USER_GUIDE.md`. Closes #114. ## Threading notes No worker/signal changes — this only adjusts what the main thread does with state it already owns (`status_label`, `progress_bar`) at a point where it was already executing synchronously. No `QWidget`/model access was added to a worker thread. ## Test plan - [x] `ruff check` / `ruff format --check` on `src`, `tests`, `scripts` - [x] `pytest` — 540 passed, 1 skipped - [x] `./scripts/check-version-bump.sh` — passes (0.2.2 → 0.2.3) - [x] `QT_QPA_PLATFORM=offscreen ./scripts/smoke-ui-exit.sh` — clean teardown, no Qt shutdown errors - [x] `pip install -e .` in the active venv — `scripts/get-version.py --canonical` resolves to `0.2.3`

Claude added 2 commits 2026-06-24 04:26:36 +00:00

fix(scan): show finalizing status during post-scan cleanup (#114) ... f5851458eb

The scan progress bar froze with no feedback between the "Indexing"
phase completing and "Scan Complete" appearing: _on_deep_finished runs
several synchronous main-thread steps (recent-dir bookkeeping, dupe-tag
pruning, optional network-share cache sync) before updating the status
label. Show a "Finalizing scan..." message with a busy indicator as
soon as the scan finishes, and surface real progress for the
network-share sync instead of running it silently.

Bump dev VERSION to 0.2.2-bug.114 (Kind/Bug, issue #114).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

docs: PR-prep — bump to 0.2.3 for issue #114 scan-finalize fix ... 88d4f772ed

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ValleyGeek merged commit ffb727b63b into main 2026-06-24 04:29:56 +00:00

ValleyGeek deleted branch 0.2.2/issue-114-soft-lock-after-scan 2026-06-24 04:29:57 +00:00

ValleyGeek referenced this pull request from a commit 2026-06-24 04:29:58 +00:00

fix(scan): show finalizing status during post-scan cleanup (#114) (#135)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Kind/Bug

Something isn't working as expected

  

Kind/Feature

New capability or user-requested feature

  

Priority/High

High priority

  

Priority/Medium

Medium priority

  

Reviewed/Confirmed

Bug or feature report confirmed valid

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Kind/Bug

Kind/Feature

Priority/High

Priority/Medium

Reviewed/Confirmed

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ai-collab/bulk-image-organizer!135

No description provided.