fix(viewer): load tall images past Qt's allocation limit; always display full resolution #134

Merged

ValleyGeek merged 3 commits from 0.2.1/issue-117-tall-image-not-rendering into main 2026-06-24 01:47:07 +00:00

Conversation 0 Commits 3 Files changed 7 +121 -10

Claude commented 2026-06-24 01:46:43 +00:00

Member

Copy link

Summary

• Fixes #117: a 1569x42895 image (and any image needing >256 MB at 4 bytes/pixel) silently failed to load because QImage(path) uses Qt's default 256 MB QImageReader allocation limit before any downscaling runs. The viewer fell back to showing the previously loaded image, and the Duplicates Multi view showed a blank canvas, with no error surfaced (isNull() returns True without raising). Now loads via QImageReader directly with the allocation limit raised to 1024 MB.
• While in this code: the viewer was pre-downscaling every image to a 2048px max edge before display, so zooming in past 100% upscaled that reduced copy and looked blurry even when the source file had far more detail. ViewerImageLoader/enqueue_viewer_image_load now support max_edge=None to skip that downscale; the existing fit-to-window transform already handles shrinking the full-resolution image for the default view. All four viewer load sites (initial load, neighbor prefetch, post-rotation reload) now request full resolution. The duplicate-comparison multi-pane grid (dupe_multi_grid.py) keeps its prior capped default unchanged, since it's a separate, more memory-sensitive view.
• Version bumped 0.2.1 → 0.2.2 (compiled inputs changed); CHANGELOG and USER_GUIDE updated.

Test plan

• New regression test tests/test_viewer_image_loader.py reproduces the exact failing dimensions (1569x42895) and confirms it now loads and downscales correctly
• New test confirms max_edge=None returns true full resolution instead of the capped size
• Full suite: pytest — 540 passed, 1 skipped
• ruff check / ruff format --check clean
• ./scripts/smoke-ui-exit.sh (offscreen) — clean Qt teardown, no shutdown errors
• ./scripts/check-version-bump.sh passes
• Manual verification: synthetic large test images load and report correct full-resolution dimensions through ViewerImageLoader

🤖 Generated with Claude Code

## Summary - Fixes #117: a 1569x42895 image (and any image needing >256 MB at 4 bytes/pixel) silently failed to load because `QImage(path)` uses Qt's default 256 MB `QImageReader` allocation limit before any downscaling runs. The viewer fell back to showing the previously loaded image, and the Duplicates Multi view showed a blank canvas, with no error surfaced (`isNull()` returns `True` without raising). Now loads via `QImageReader` directly with the allocation limit raised to 1024 MB. - While in this code: the viewer was pre-downscaling every image to a 2048px max edge before display, so zooming in past 100% upscaled that reduced copy and looked blurry even when the source file had far more detail. `ViewerImageLoader`/`enqueue_viewer_image_load` now support `max_edge=None` to skip that downscale; the existing fit-to-window transform already handles shrinking the full-resolution image for the default view. All four viewer load sites (initial load, neighbor prefetch, post-rotation reload) now request full resolution. The duplicate-comparison multi-pane grid (`dupe_multi_grid.py`) keeps its prior capped default unchanged, since it's a separate, more memory-sensitive view. - Version bumped 0.2.1 → 0.2.2 (compiled inputs changed); CHANGELOG and USER_GUIDE updated. ## Test plan - [x] New regression test `tests/test_viewer_image_loader.py` reproduces the exact failing dimensions (1569x42895) and confirms it now loads and downscales correctly - [x] New test confirms `max_edge=None` returns true full resolution instead of the capped size - [x] Full suite: `pytest` — 540 passed, 1 skipped - [x] `ruff check` / `ruff format --check` clean - [x] `./scripts/smoke-ui-exit.sh` (offscreen) — clean Qt teardown, no shutdown errors - [x] `./scripts/check-version-bump.sh` passes - [x] Manual verification: synthetic large test images load and report correct full-resolution dimensions through `ViewerImageLoader` 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Claude added 3 commits 2026-06-24 01:46:43 +00:00

fix(viewer): raise Qt image allocation limit so tall/large images load (#117) ... 2161f49bc5

QImage(path) implicitly uses QImageReader's default 256 MB allocation
limit before any of our downscaling runs. A 1569x42895 image needs
~256.7 MB at 4 bytes/pixel, just over that limit, so Qt silently
returns a null image — the viewer then keeps showing the previously
loaded image and the duplicate multi-view shows a blank canvas, with
no error surfaced since isNull() returns True without raising.

Load via QImageReader directly and raise the allocation limit to
1024 MB (VIEWER_IMAGE_ALLOCATION_LIMIT_MB) before reading, so the
existing post-load downscale to VIEWER_MAX_DISPLAY_EDGE still applies
normally.

Threading notes: ViewerImageLoader.run() still executes entirely on
the worker thread and only emits plain QImage/str data via
ViewerImageSignals; no widget/model access was added.

VERSION: 0.2.1-bug.117 (dev suffix for issue #117, Kind/Bug).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(viewer): always display full-resolution images (#117) ... 80e22ea62b

The image viewer pre-downscaled every loaded image to a 2048px max
edge before display, then relied on the view's fit-to-window scale to
shrink it further for on-screen display. Zooming in past 100% then
upscaled that already-reduced pixel data, producing visibly blurry
detail even though the original file had far more resolution.

ViewerImageLoader/enqueue_viewer_image_load now accept max_edge=None
to skip the pixel-data downscale entirely; the existing fit-to-window
transform in image_viewer.py already scales the full-resolution
QPixmap down for the default view, so this only changes what's
available when zooming in. All four viewer load sites (initial load,
neighbor prefetch, post-rotation reload) now pass max_edge=None.
core/dupe_multi_grid.py keeps the prior capped default unchanged,
since that multi-pane comparison view is a separate, more
memory-sensitive use of the same loader.

Threading notes: no change to the threading contract — the worker
still does all image decode/scale work off the main thread and emits
only a QImage via ViewerImageSignals.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

docs: PR-prep — bump to 0.2.2 for issue #117 viewer fixes ... d9c3139b9d

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ValleyGeek merged commit 01d5bbbfa5 into main 2026-06-24 01:47:07 +00:00

ValleyGeek deleted branch 0.2.1/issue-117-tall-image-not-rendering 2026-06-24 01:47:07 +00:00

ValleyGeek referenced this pull request from a commit 2026-06-24 01:47:10 +00:00

fix(viewer): load tall images past Qt's allocation limit; always display full resolution (#134)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Kind/Bug

Something isn't working as expected

  

Kind/Feature

New capability or user-requested feature

  

Priority/High

High priority

  

Priority/Medium

Medium priority

  

Reviewed/Confirmed

Bug or feature report confirmed valid

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Kind/Bug

Kind/Feature

Priority/High

Priority/Medium

Reviewed/Confirmed

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ai-collab/bulk-image-organizer!134

No description provided.