feat(thumbnails): configurable thumbnail generation thread count (#64) #124

Merged

ValleyGeek merged 3 commits from 0.1.42/issue-64-thumbnail-threads into main

2026-06-22 01:42:33 +00:00

Claude commented

2026-06-22 00:34:53 +00:00

Member

Summary

#64 — generate_thumbnails_for_db() (core/thumbnail_batch.py) now decodes/resizes/encodes each batch's images across a ThreadPoolExecutor instead of strictly sequentially. New "Thumbnail generation threads" advanced setting (Settings → Advanced, default 2, range 1-16) controls the pool size; ThumbnailWorker forwards it as max_workers.
The executor is used solely for the pure-function generate_thumbnail_jpeg() call (file read + Pillow decode/resize/encode, no DB or Qt access). All WorkingDB writes and progress callbacks still happen only on the calling thread (the ThumbnailWorker's own QRunnable thread), preserving the Threading Contract — multiple helper threads never touch the DB, model, or any QWidget/QPixmap/QGraphics* object.

Test plan

ruff check / ruff format --check
pytest
PR-prep version bump 0.1.42 → 0.1.43

Refs #64. (Further follow-up tuning to this feature — a benchmark/auto-tune button and live-scan parallelization — lands in the final PR of this chain.)

Stacked on #123 — part of the 11-PR sequential chain into main.

## Summary - **#64** — `generate_thumbnails_for_db()` (`core/thumbnail_batch.py`) now decodes/resizes/encodes each batch's images across a `ThreadPoolExecutor` instead of strictly sequentially. New "Thumbnail generation threads" advanced setting (Settings → Advanced, default 2, range 1-16) controls the pool size; `ThumbnailWorker` forwards it as `max_workers`. - The executor is used solely for the pure-function `generate_thumbnail_jpeg()` call (file read + Pillow decode/resize/encode, no DB or Qt access). All WorkingDB writes and progress callbacks still happen only on the calling thread (the `ThumbnailWorker`'s own `QRunnable` thread), preserving the Threading Contract — multiple helper threads never touch the DB, model, or any `QWidget`/`QPixmap`/`QGraphics*` object. ## Test plan - [x] `ruff check` / `ruff format --check` - [x] `pytest` - [x] PR-prep version bump 0.1.42 → 0.1.43 Refs #64. (Further follow-up tuning to this feature — a benchmark/auto-tune button and live-scan parallelization — lands in the final PR of this chain.) Stacked on #123 — part of the 11-PR sequential chain into `main`.

Claude added 3 commits

2026-06-22 00:34:53 +00:00

test(release-notes): decouple CHANGELOG tests from real repo file state 609962dcfe

test_changelog_section_returns_none_for_empty_unreleased and
test_dev_body_falls_back_when_unreleased_empty read the actual CHANGELOG.md
in this repo via _changelog_section()'s hardcoded REPO_ROOT, asserting
[Unreleased] is empty. That's only true between releases — any branch that
legitimately adds an Unreleased entry (e.g. a CI-only change with no version
bump) breaks these tests with no code regression. Monkeypatch REPO_ROOT to a
synthetic CHANGELOG.md so the fallback-path behavior is tested directly
instead of depending on incidental repo state.

feat(thumbnails): configurable thumbnail generation thread count 23f0c6258b

generate_thumbnails_for_db() (core/thumbnail_batch.py) now decodes/resizes/
encodes each batch's images across a ThreadPoolExecutor instead of strictly
sequentially. New "Thumbnail generation threads" advanced setting (Settings →
Advanced, default 2, range 1-16) controls the pool size; ThumbnailWorker
forwards it as max_workers, and both call sites in main_window.py read it via
a new _thumbnail_worker_threads() helper (mirroring _dupe_tag_padding()).

Threading notes: the executor is used solely for the pure-function
generate_thumbnail_jpeg() call (file read + Pillow decode/resize/encode, no
DB or Qt access). All WorkingDB writes and on_progress/on_batch callbacks
still happen only on the calling thread (the ThumbnailWorker's own QRunnable
thread), preserving the "connections are short-lived, never shared across
threads" contract — multiple helper threads never touch the DB, model, or any
QWidget/QPixmap/QGraphics* object. Default of 1 is unchanged for any other
direct caller of generate_thumbnails_for_db() that doesn't pass max_workers.

Fixes #64

docs: PR-prep for issue 64 - bump to 0.1.43

CI / lint (push) Successful in 7s

Details

CI / test (push) Successful in 1m52s

Details

CI / appimage (push) Successful in 8m27s

Details

CI / build-appimage (push) Successful in 0s

Details

CI / windows-exe (push) Failing after 10m34s

Details

CI / build-windows-exe (push) Failing after 0s