fix(ci): drop redundant pull_request trigger, name prune runs #105

Merged

ValleyGeek merged 2 commits from 0.1.35-enhancement.103 into main 2026-06-19 18:04:03 +00:00

Conversation 0 Commits 2 Files changed 4 +4 -12

Claude commented 2026-06-19 16:25:16 +00:00

Member

Copy link

Summary

Follow-up to #103 / #104, found while watching the merged PR's checks: ci.yml still triggered on both push (any branch) and pull_request (to main), so every push to a branch with an open PR produced two full ci.yml runs for the identical commit — visible on the PR as duplicate same-named jobs suffixed -1 (build-appimage-1, build-windows-exe-1).

• Drop the pull_request trigger from ci.yml. All branches in this repo are same-repo (never forks), so the push-triggered run already reports status checks against the PR's head commit; the separate trigger added no coverage, only a redundant lint/test run.
• Add run-name: to prune-dev-release.yml and prune-orphaned-releases.yml. Both fire on events with no associated commit (delete, schedule), so their Actions-list run titles defaulted to the bare workflow name with no indication of which branch was pruned / which sweep ran. They now show Prune dev release: <branch> and Scheduled dev-release sweep #<run-number>.
• docs/DECISIONS.md DR-022 updated to record both.

No application code changed; VERSION stays 0.1.35.

Test plan

• ruff check . && ruff format --check .
• pytest (363 passed, 1 skipped)
• Validated both edited workflow YAML files parse (yaml.safe_load)
• Confirm the next push to a branch with an open PR shows a single, unduplicated job set (no -1 suffixes)
• Confirm the next branch deletion / scheduled sweep run shows the new informative run-name in the Actions list

## Summary Follow-up to #103 / #104, found while watching the merged PR's checks: `ci.yml` still triggered on both `push` (any branch) and `pull_request` (to `main`), so every push to a branch with an open PR produced two full `ci.yml` runs for the identical commit — visible on the PR as duplicate same-named jobs suffixed `-1` (`build-appimage-1`, `build-windows-exe-1`). - Drop the `pull_request` trigger from `ci.yml`. All branches in this repo are same-repo (never forks), so the `push`-triggered run already reports status checks against the PR's head commit; the separate trigger added no coverage, only a redundant lint/test run. - Add `run-name:` to `prune-dev-release.yml` and `prune-orphaned-releases.yml`. Both fire on events with no associated commit (`delete`, `schedule`), so their Actions-list run titles defaulted to the bare workflow name with no indication of which branch was pruned / which sweep ran. They now show `Prune dev release: <branch>` and `Scheduled dev-release sweep #<run-number>`. - `docs/DECISIONS.md` DR-022 updated to record both. No application code changed; `VERSION` stays `0.1.35`. ## Test plan - [x] `ruff check . && ruff format --check .` - [x] `pytest` (363 passed, 1 skipped) - [x] Validated both edited workflow YAML files parse (`yaml.safe_load`) - [ ] Confirm the next push to a branch with an open PR shows a single, unduplicated job set (no `-1` suffixes) - [ ] Confirm the next branch deletion / scheduled sweep run shows the new informative run-name in the Actions list

Claude added 5 commits 2026-06-19 16:25:16 +00:00

fix(ci): single-trigger gated release pipeline with user-facing release notes ... fab42b66ec

linux-appimage.yml and windows-release.yml each declared their own
independent push trigger in addition to being called via workflow_call
from ci.yml, so dev-branch release builds fired immediately on push,
ungated by lint/test, racing the ci.yml pipeline. Both workflows also
carried dead workflow_run branch-resolution code for an event they never
declared, which live release history shows produced PR#-numbered release
titles (e.g. "Bulk Image Organizer Dev (102)") instead of branch names.

ci.yml is now the sole trigger for release builds: the reusable workflows
keep only workflow_call/workflow_dispatch, run for any push (gated on
needs: test, never on pull_request), and resolve branch/sha only from the
real git ref. Job ids are renamed to describe the deliverable
(build-appimage, build-windows-exe). ci.yml gains its own concurrency
group so redundant lint/test runs on the same branch cancel each other.

Release bodies are now generated by scripts/build-release-notes.py, which
extracts the matching CHANGELOG.md section instead of repeating the title.

feat(ci): reconcile orphaned dev Forgejo releases against existing branches ... 4de85016c4

prune-dev-release.yml only fires on a single branch's delete webhook and
has no way to recover a missed event or clear backlog. A live audit found
12 of 19 releases on the real instance were orphaned (branch gone, or a
PR#-numbered duplicate of a correctly-named dev release).

scripts/prune-orphaned-dev-releases.py lists releases and branches via the
Forgejo API, keeps every v{version} tag plus any dev-* tag whose slug
matches a live branch, and deletes the rest. It's wired into
scripts/prune-merged-branches.py (run by agents per AGENTS.md step 8, with
a --skip-release-prune escape hatch) and into a new best-effort daily
schedule workflow, prune-orphaned-releases.yml, as a second safety net.

docs: record CI release-pipeline redesign (DR-022) f7f1a275f0

fix(ci): drop redundant pull_request trigger from ci.yml ... 9ae3eaa8b4

Every push to a branch with an open PR produced two full ci.yml runs for
the identical commit (one push-triggered, one pull_request-triggered),
visible on the PR as duplicate same-named jobs suffixed -1. All branches
in this repo are same-repo (never forks), so the push-triggered run's
status checks already cover the PR's head commit; the separate
pull_request trigger added no coverage, only redundant lint/test runs.

fix(ci): give prune workflows an informative run-name ... 086554acb6

delete and schedule events have no commit message, so these runs showed
up in the Actions list with only the bare workflow name. run-name (same
GitHub Actions schema field Forgejo Actions implements) now shows the
pruned branch / sweep run number, distinguishing them from the
commit-message-titled build/CI runs.

Claude force-pushed 0.1.35-enhancement.103 from 086554acb6 to 1d57698b0b 2026-06-19 17:46:51 +00:00 Compare

ValleyGeek merged commit 3a2711b192 into main 2026-06-19 18:04:03 +00:00

ValleyGeek deleted branch 0.1.35-enhancement.103 2026-06-19 18:04:03 +00:00

ValleyGeek referenced this pull request from a commit 2026-06-19 18:04:06 +00:00

fix(ci): drop redundant pull_request trigger, name prune runs (#105)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Kind/Bug

Something isn't working as expected

  

Kind/Feature

New capability or user-requested feature

  

Priority/High

High priority

  

Priority/Medium

Medium priority

  

Reviewed/Confirmed

Bug or feature report confirmed valid

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Kind/Bug

Kind/Feature

Priority/High

Priority/Medium

Reviewed/Confirmed

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ai-collab/bulk-image-organizer!105

No description provided.