fix(ci): stop shared release tag from poisoning the other platform's build check #101

Closed

Claude wants to merge 1 commit from 0.1.34-adhoc.windows-release-skip-fix into main

pull from: 0.1.34-adhoc.windows-release-skip-fix

merge into: ai-collab:main

ai-collab:main

ai-collab:0.2.2/issue-115-dupe-color-coding

Conversation 1 Commits 1 Files changed 2 +102 -17

Claude commented 2026-06-19 05:52:00 +00:00

Member

Copy link

Summary

• PR #100 merged correctly but the Windows release was silently skipped: release-linux and release-windows both publish to the same per-version release tag (e.g. v0.1.34), and release_build_needed.py treated "release tag already targets this commit" as "this platform already built it." Since Linux's job published v0.1.34 first, the Windows job's check then saw the tag pointing at the same head SHA and skipped its own build entirely — even though only the Linux .AppImage asset was ever attached. Confirmed via the Forgejo release API: v0.1.34 currently has only BulkImageOrganizer_0.1.34.AppImage, no .exe.
• Fixes resolve_diff_base() to only take the "already built" shortcut when the release actually has an asset for the platform being checked (.exe for windows, .AppImage for linux), not just when the tag's target_commitish matches head. fetch_release_target_sha is replaced with fetch_release_info, which also returns the release's asset names.
• No VERSION bump — this only touches scripts/release_build_needed.py and its test, not compiled inputs.

Test plan

• ruff check . / ruff format --check .
• pytest — full suite passes (349 passed, 1 skipped)
• Added regression tests: a release tag already targeting head with only the other platform's asset no longer short-circuits to "already built"; a release with the matching platform asset still does.

🤖 Generated with Claude Code

## Summary - PR #100 merged correctly but the Windows release was silently skipped: `release-linux` and `release-windows` both publish to the same per-version release tag (e.g. `v0.1.34`), and `release_build_needed.py` treated "release tag already targets this commit" as "this platform already built it." Since Linux's job published `v0.1.34` first, the Windows job's check then saw the tag pointing at the same head SHA and skipped its own build entirely — even though only the Linux `.AppImage` asset was ever attached. Confirmed via the Forgejo release API: `v0.1.34` currently has only `BulkImageOrganizer_0.1.34.AppImage`, no `.exe`. - Fixes `resolve_diff_base()` to only take the "already built" shortcut when the release actually has an asset for the platform being checked (`.exe` for windows, `.AppImage` for linux), not just when the tag's `target_commitish` matches head. `fetch_release_target_sha` is replaced with `fetch_release_info`, which also returns the release's asset names. - No `VERSION` bump — this only touches `scripts/release_build_needed.py` and its test, not compiled inputs. ## Test plan - [x] `ruff check .` / `ruff format --check .` - [x] `pytest` — full suite passes (349 passed, 1 skipped) - [x] Added regression tests: a release tag already targeting head with only the *other* platform's asset no longer short-circuits to "already built"; a release with the matching platform asset still does. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Claude added 1 commit 2026-06-19 05:52:00 +00:00

fix(ci): stop shared release tag from poisoning the other platform's build-needed check ... 48e2c4ca72

Linux and Windows release jobs publish to the same per-version release
tag (e.g. v0.1.34). release_build_needed.py treated "release tag already
targets this commit" as "this platform already built it," so whichever
platform's job ran second after the other had already published saw the
tag pointing at head_sha and skipped its own build entirely — even though
only the other platform's asset was attached. This is what happened to
the Windows build on PR #100: Linux published v0.1.34 first, and the
Windows job then skipped with a false "already built" reason.

Gate the already-built shortcut on the release actually carrying an
asset for the platform being checked (.exe for windows, .AppImage for
linux), not just on the tag's target_commitish matching head.

Claude referenced this pull request from a commit 2026-06-19 05:58:40 +00:00

fix(ci): stop shared release tag from poisoning the other platform's build-needed check (#101)

Claude commented 2026-06-19 05:59:00 +00:00

Author

Member

Copy link

Merged manually to main as b30228b (squash, matching this PR's diff exactly) so the fixed release_build_needed.py is in place before dispatching the Windows backfill build for v0.1.34.

Merged manually to `main` as b30228b (squash, matching this PR's diff exactly) so the fixed `release_build_needed.py` is in place before dispatching the Windows backfill build for v0.1.34.

Claude closed this pull request 2026-06-19 05:59:11 +00:00

All checks were successful

Hide all checks

CI / lint (push) Successful in 7s

Details

CI / test (push) Successful in 2m4s

Details

CI / test (pull_request) Successful in 2m2s

Details

CI / lint (pull_request) Successful in 13s

Details

Windows Release / build-release (push) Successful in 10m9s

Details

Linux AppImage / build-release (push) Successful in 10m15s

Details

CI / build-release-1 (push) Successful in 14s

Details

CI / release-windows (push) Successful in 0s

Details

CI / build-release (push) Successful in 12m32s

Details

CI / release-linux (push) Successful in 0s

Details

CI / build-release (pull_request) Successful in 12m48s

Details

CI / release-linux (pull_request) Successful in 0s

Details

CI / build-release-1 (pull_request) Successful in 8m59s

Details

CI / release-windows (pull_request) Successful in 0s

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Kind/Bug

Something isn't working as expected

  

Kind/Feature

New capability or user-requested feature

  

Priority/High

High priority

  

Priority/Medium

Medium priority

  

Reviewed/Confirmed

Bug or feature report confirmed valid

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Kind/Bug

Kind/Feature

Priority/High

Priority/Medium

Reviewed/Confirmed

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ai-collab/bulk-image-organizer!101

No description provided.