Fix Windows main window restoring off-screen after fullscreen (fixes #26) #69

Merged

ValleyGeek merged 2 commits from 0.1.25/issue-26-window-offscreen into main 2026-06-13 01:00:45 +00:00

Conversation 0 Commits 2 Files changed 5 +186 -19

Grok commented 2026-06-13 00:58:51 +00:00

Member

Copy link

Summary

Fixes #26 — on Windows, reopening the app after a fullscreen session could place the main window above the visible desktop so the title bar and window controls were unreachable.

Root cause

Session restore saved frameGeometry() but applied values through setGeometry(). On Windows those APIs disagree about client vs. frame size, so a fullscreen-sized rect could push the title bar above the work area when Qt tried to avoid the taskbar.

Changes

• session_state.py: Persist Qt saveGeometry() (qt_geometry) and target screen name for platform-correct restore.
• Fullscreen path: Skip manual setGeometry; re-enter fullscreen on the saved monitor via windowHandle().setScreen() + showFullScreen().
• Legacy fallback: Frame-aware clamp nudges and shrinks windows until the frame fits inside availableGeometry.
• main_window.py: Remove duplicate deferred showFullScreen (handled in session restore).
• Tests: Extended test_pr13_config.py with qt-geometry round-trip, fullscreen re-entry, and legacy off-screen rect cases.

Verification

• ruff check / ruff format --check
• pytest tests/test_pr13_config.py (25 passed)
• ./scripts/check-version-bump.sh

Version

0.1.26 (patch)

## Summary Fixes #26 — on Windows, reopening the app after a fullscreen session could place the main window above the visible desktop so the title bar and window controls were unreachable. ## Root cause Session restore saved `frameGeometry()` but applied values through `setGeometry()`. On Windows those APIs disagree about client vs. frame size, so a fullscreen-sized rect could push the title bar above the work area when Qt tried to avoid the taskbar. ## Changes - **`session_state.py`**: Persist Qt `saveGeometry()` (`qt_geometry`) and target `screen` name for platform-correct restore. - **Fullscreen path**: Skip manual `setGeometry`; re-enter fullscreen on the saved monitor via `windowHandle().setScreen()` + `showFullScreen()`. - **Legacy fallback**: Frame-aware clamp nudges and shrinks windows until the frame fits inside `availableGeometry`. - **`main_window.py`**: Remove duplicate deferred `showFullScreen` (handled in session restore). - **Tests**: Extended `test_pr13_config.py` with qt-geometry round-trip, fullscreen re-entry, and legacy off-screen rect cases. ## Verification - `ruff check` / `ruff format --check` - `pytest tests/test_pr13_config.py` (25 passed) - `./scripts/check-version-bump.sh` ## Version `0.1.26` (patch)

Grok added 1 commit 2026-06-13 00:58:51 +00:00

fix(windows): restore main window geometry without off-screen title bar ... 894f8851bb

Persist Qt saveGeometry payloads and target screen names so Windows
sessions restore through platform-aware APIs instead of raw frame rects.
Fullscreen sessions re-enter fullscreen on the saved monitor without a
preceding setGeometry call that pushed the frame above the desktop.
Legacy saved rects are clamped with a frame-aware position and size pass.

Fixes #26 on branch 0.1.25/issue-26-window-offscreen.

Grok added 1 commit 2026-06-13 00:58:53 +00:00

docs: PR-prep for issue 26 — Windows window geometry restore ... d8217ea64c

Bump VERSION to 0.1.26 and document the fullscreen off-screen restore fix.

Grok referenced this pull request 2026-06-13 00:58:55 +00:00

[Bug]: Main Window Lanches outside screen space #26

ValleyGeek merged commit b2e0ada2ad into main 2026-06-13 01:00:45 +00:00

ValleyGeek deleted branch 0.1.25/issue-26-window-offscreen 2026-06-13 01:00:46 +00:00

ValleyGeek referenced this pull request from a commit 2026-06-13 01:00:46 +00:00

Fix Windows main window restoring off-screen after fullscreen (fixes #26) (#69)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Kind/Bug

Something isn't working as expected

  

Kind/Feature

New capability or user-requested feature

  

Priority/High

High priority

  

Priority/Medium

Medium priority

  

Reviewed/Confirmed

Bug or feature report confirmed valid

  

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Kind/Bug

Kind/Feature

Priority/High

Priority/Medium

Reviewed/Confirmed

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ai-collab/bulk-image-organizer!69

No description provided.