[Feature]: Select 'Keep' Option in Duplicate Workbench

ValleyGeek commented

2026-06-24 05:17:39 +00:00

Owner

Problem or use case

Grant the user more autonomy when selecting which image to keep

Proposed solution

Replace the keep behavior in the duplicate workbench.

To the right of the 'Single' button add a vertical separator
Add a new button to the right of the separator "Keep:"
Add a new drop down to the right of "Keep" with:
- File Size - Largest
- File Size - Smallest
- Resolution - Largest
- Resolution - Smallest
- Sharpness - Largest
- Sharpness - Smallest
- Filename - Longest
- Filename - Shortest
- Directory - Longest
  - Using the name of the single directory the image is in
- Directory - Shortest
- Relative Path - Longest
  - Using the full relative path + filename
- Relative Path - Shortest
Set key "c" to be equivalent to selecting the "keep" button
Add a toggle button "AoK" (Advance on Keep) with tool tip explaining its purpose
Add another vertical separator between AoK and "Delete Group"

### Problem or use case Grant the user more autonomy when selecting which image to keep ### Proposed solution Replace the keep behavior in the duplicate workbench. - To the right of the 'Single' button add a vertical separator - Add a new button to the right of the separator "Keep:" - Add a new drop down to the right of "Keep" with: - File Size - Largest - File Size - Smallest - Resolution - Largest - Resolution - Smallest - Sharpness - Largest - Sharpness - Smallest - Filename - Longest - Filename - Shortest - Directory - Longest - Using the name of the single directory the image is in - Directory - Shortest - Relative Path - Longest - Using the full relative path + filename - Relative Path - Shortest - Set key "c" to be equivalent to selecting the "keep" button - Add a toggle button "AoK" (Advance on Keep) with tool tip explaining its purpose - Add another vertical separator between AoK and "Delete Group"

ValleyGeek added the

Kind/Feature

Priority/Medium

labels

2026-06-24 05:17:39 +00:00

Claude referenced this issue from a commit

2026-06-24 13:17:22 +00:00

feat(dupe): add Keep dropdown criteria and AoK toggle (#136)

Claude referenced this issue from a commit

2026-06-24 13:34:19 +00:00

test(dupe): cover keep-criteria selection and shortcut (#136)

Claude referenced this issue from a commit

2026-06-24 13:40:15 +00:00

docs: PR-prep — bump to 0.2.5 for issue #136 Keep dropdown

Claude commented

2026-06-24 13:40:52 +00:00

Member

Implemented on branch 0.2.4/issue-136-keep-dropdown (stacked on 0.2.4/issue-138-dupe-grid-view), pushed and awaiting PR/merge.

What changed:

Duplicates workbench toolbar: replaced the single "Keep Best" button with a "Keep:" button + criterion dropdown, positioned right of "Single" with a vertical separator on each side, matching the requested layout.
Dropdown offers all 12 requested criteria (File Size, Resolution, Sharpness, Filename, Directory, Relative Path — each Largest/Longest or Smallest/Shortest), default Resolution - Largest (matches the prior Keep Best behavior). New KEEP_CRITERIA / DEFAULT_KEEP_CRITERION / pick_keep_path_by_criterion() / keep_by_criterion_delete_paths() in core/dupe_detector.py; ties break alphabetically by relative path.
"AoK" (Advance on Keep) toggle button added between the dropdown and "Delete Group" (with its own separator before Delete Group), on by default, with a tooltip explaining it auto-advances to the next group after Keep — turning it off keeps the workbench on the same group.
c is wired as the default shortcut for the new dupe_keep action via the existing shortcut-registry/override mechanism (shown as "C" in Settings → Shortcuts), and overridable like other shortcuts.

Testing: new unit coverage for the criterion-picking helpers and fallback-on-unknown-id behavior (tests/test_pr11_dupe.py), the default shortcut (tests/test_pr13_config.py), and the new dropdown/AoK widgets + MainWindow._on_dupe_keep_best integration (tests/test_dupe_keep_criteria.py). Full suite (587 tests) passes; ruff check/ruff format --check clean; scripts/smoke-ui-exit.sh clean.

Docs: resources/help/USER_GUIDE.md, docs/DESIGN.md, docs/TECHNICAL_OUTLINE.md updated; VERSION bumped to 0.2.5 per PR-prep policy with a CHANGELOG.md entry.

Commits: 19823a8 (feature), 400f0f9 (tests), e3da1ba (PR-prep/docs/version).

Implemented on branch `0.2.4/issue-136-keep-dropdown` (stacked on `0.2.4/issue-138-dupe-grid-view`), pushed and awaiting PR/merge. **What changed:** - Duplicates workbench toolbar: replaced the single "Keep Best" button with a "Keep:" button + criterion dropdown, positioned right of "Single" with a vertical separator on each side, matching the requested layout. - Dropdown offers all 12 requested criteria (File Size, Resolution, Sharpness, Filename, Directory, Relative Path — each Largest/Longest or Smallest/Shortest), default `Resolution - Largest` (matches the prior Keep Best behavior). New `KEEP_CRITERIA` / `DEFAULT_KEEP_CRITERION` / `pick_keep_path_by_criterion()` / `keep_by_criterion_delete_paths()` in `core/dupe_detector.py`; ties break alphabetically by relative path. - "AoK" (Advance on Keep) toggle button added between the dropdown and "Delete Group" (with its own separator before Delete Group), on by default, with a tooltip explaining it auto-advances to the next group after Keep — turning it off keeps the workbench on the same group. - `c` is wired as the default shortcut for the new `dupe_keep` action via the existing shortcut-registry/override mechanism (shown as "C" in Settings → Shortcuts), and overridable like other shortcuts. **Testing:** new unit coverage for the criterion-picking helpers and fallback-on-unknown-id behavior (`tests/test_pr11_dupe.py`), the default shortcut (`tests/test_pr13_config.py`), and the new dropdown/AoK widgets + `MainWindow._on_dupe_keep_best` integration (`tests/test_dupe_keep_criteria.py`). Full suite (587 tests) passes; `ruff check`/`ruff format --check` clean; `scripts/smoke-ui-exit.sh` clean. **Docs:** `resources/help/USER_GUIDE.md`, `docs/DESIGN.md`, `docs/TECHNICAL_OUTLINE.md` updated; `VERSION` bumped to `0.2.5` per PR-prep policy with a `CHANGELOG.md` entry. Commits: `19823a8` (feature), `400f0f9` (tests), `e3da1ba` (PR-prep/docs/version).

Claude added the

Reviewed/Confirmed

label

2026-06-24 13:41:02 +00:00

Claude referenced this issue from a commit

2026-06-24 13:44:26 +00:00

fix(release): correct issue #136 PR-prep version to 0.3.1

Claude referenced this issue from a commit

2026-06-24 14:13:27 +00:00

docs: PR-prep — bump to 0.3.4 for issue #116 Reveal in Filesystem

Claude referenced this issue from a commit

2026-06-25 00:04:04 +00:00

feat(dupe): add Keep dropdown criteria and AoK toggle (#136)

Claude referenced this issue from a commit

2026-06-25 00:04:04 +00:00

test(dupe): cover keep-criteria selection and shortcut (#136)

Claude referenced this issue from a commit

2026-06-25 00:04:04 +00:00

docs: PR-prep — bump to 0.2.5 for issue #136 Keep dropdown

Claude referenced this issue from a commit

2026-06-25 00:04:04 +00:00

fix(release): correct issue #136 PR-prep version to 0.3.1

Claude referenced this issue from a commit

2026-06-25 00:30:32 +00:00

fix(dupe): Keep label/default, configurable default, clear DELETE on keeper

Claude referenced this issue from a commit

2026-06-25 00:30:32 +00:00

docs: update issue #136 changelog entry to match final behavior

Claude commented

2026-06-25 00:30:36 +00:00

Member

Follow-up after review feedback, pushed to the same branch (0.2.4/issue-136-keep-dropdown):

Removed the colon from the button label: "Keep:" → "Keep".
Default criterion changed from Resolution - Largest to File Size - Largest.
The default is now configurable: Settings → Duplicates → "Default Keep criterion".
Pressing Keep now clears DELETE from the chosen image if an earlier Keep press (with a different criterion) had already marked it, instead of only ever adding DELETE to the losers.

Still open pending PR/merge to main.

Follow-up after review feedback, pushed to the same branch (`0.2.4/issue-136-keep-dropdown`): - Removed the colon from the button label: "Keep:" → "Keep". - Default criterion changed from Resolution - Largest to File Size - Largest. - The default is now configurable: Settings → Duplicates → "Default Keep criterion". - Pressing Keep now clears DELETE from the chosen image if an earlier Keep press (with a different criterion) had already marked it, instead of only ever adding DELETE to the losers. Still open pending PR/merge to `main`.

Claude referenced this issue from a commit

2026-06-25 00:46:31 +00:00

docs: PR-prep — bump to 0.3.4 for issue #116 Reveal in Filesystem

Claude referenced this issue from a commit

2026-06-25 04:54:54 +00:00

feat(dupe): add Keep dropdown criteria and AoK toggle (#136)

Claude referenced this issue from a commit

2026-06-25 04:54:54 +00:00

test(dupe): cover keep-criteria selection and shortcut (#136)

Claude referenced this issue from a commit

2026-06-25 04:54:54 +00:00

docs: PR-prep — bump to 0.2.5 for issue #136 Keep dropdown