feat(tagging): Advance on Tag toggle across Grid, Viewer, and Dupes (#109) #128

Merged

ValleyGeek merged 2 commits from 0.1.46/issue-109-advance-on-tag into main

2026-06-22 02:32:41 +00:00

Claude commented

2026-06-22 00:35:38 +00:00

Member

Summary

#109 — new 3-state "AoT" toolbar button next to Tag Filter (Disabled / Tags & Delete [default] / Delete Only), persisted via a global pref. When enabled, successfully adding a tag or DELETE (never on removal, and never for DUPE tags) advances the active selection:
- Grid: selects the next row.
- Image Viewer: navigates to the next image.
- Duplicate-group viewer: advances to the next non-deleted image in the group, falling back to the next duplicate group once the current one is exhausted.
The default "Tags & Delete" mode reproduces the viewer's previous unconditional advance-after-delete behavior exactly, so only users who deliberately disable AoT see a difference. See DR-026 for the scope decisions.

Test plan

ruff check / ruff format --check
pytest
PR-prep version bump 0.1.46 → 0.1.47

Refs #109. (A grid/Hide-Deleted selection-loss edge case in this feature, and the viewer-return navigation cursor not syncing with #58's WASD nav, are both fixed in the final PR of this chain.)

Stacked on #127 — part of the 11-PR sequential chain into main.

## Summary - **#109** — new 3-state "AoT" toolbar button next to Tag Filter (Disabled / Tags & Delete [default] / Delete Only), persisted via a global pref. When enabled, successfully adding a tag or DELETE (never on removal, and never for DUPE tags) advances the active selection: - Grid: selects the next row. - Image Viewer: navigates to the next image. - Duplicate-group viewer: advances to the next non-deleted image in the group, falling back to the next duplicate group once the current one is exhausted. - The default "Tags & Delete" mode reproduces the viewer's previous unconditional advance-after-delete behavior exactly, so only users who deliberately disable AoT see a difference. See DR-026 for the scope decisions. ## Test plan - [x] `ruff check` / `ruff format --check` - [x] `pytest` - [x] PR-prep version bump 0.1.46 → 0.1.47 Refs #109. (A grid/Hide-Deleted selection-loss edge case in this feature, and the viewer-return navigation cursor not syncing with #58's WASD nav, are both fixed in the final PR of this chain.) Stacked on #127 — part of the 11-PR sequential chain into `main`.

Claude added 2 commits

2026-06-22 00:35:38 +00:00

feat(tagging): Advance on Tag toggle across Grid, Viewer, and Dupes (#109 ) bc75b65680

Adds a 3-state "AoT" toolbar button next to Tag Filter (Disabled / Tags
& Delete [default] / Delete Only), persisted via a new
PREF_ADVANCE_ON_TAG_MODE global pref. When enabled, successfully adding
a tag or DELETE (never on removal, and never for DUPE tags, since
is_panel_tag() already excludes them) advances the active selection:

- Grid: selects the next row.
- Image Viewer: navigates to the next image.
- Duplicate-group viewer: advances to the next non-deleted image in
  the group (ImageViewerSub.advance_to_next_non_deleted, skipping over
  already-DELETE-tagged images), falling back to the next duplicate
  group once the current one is exhausted.

_apply_tag_toggle() and the DELETE-toggle paths (grid and viewer) now
share one _advance_after_tag_applied() dispatcher gated by the AoT
mode. This subsumes the viewer's previous unconditional
advance-after-delete behavior (advance_after_delete_marked(), now
removed as dead code) -- the default "Tags & Delete" mode reproduces
that old behavior exactly, so only users who deliberately disable AoT
see a difference. See DR-026 for the scope decisions (single persisted
toggle doubling as the "default", Multi grid excluded since it has no
single "current" position to step from).

docs: PR-prep for issue 109 - bump to 0.1.47

CI / lint (push) Successful in 8s

Details

CI / test (push) Successful in 1m52s

Details

CI / appimage (push) Successful in 8m24s

Details

CI / build-appimage (push) Successful in 0s

Details

CI / windows-exe (push) Successful in 11m30s

Details

CI / build-windows-exe (push) Successful in 0s