Battles stop showing damage numbers, hit sounds, and shake after the log reaches 8 lines #22
Labels
No labels
playtest
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ai-collab/animrpg202610#22
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Environment
345a28b(main), playtest branchfeat/playtest-bot@e03b0e8(PR #20), VERSION0.4.2--fixed-fps 60,Engine.time_scale4, Dummy audioSeen
Every battle with more than a few actions: seed 1 (61x, first at frame 711), seed 2 (69x, first at frame 666), seed 3 (57x, first at frame 494), seed 4 (66x, first at frame 605).
Repro
Automated:
bash tools/playtest/run.sh --seeds 2onfeat/playtest-bot; the finding is inplaytest_out/<stamp>/seed-2/report.md. The detector expects aFloaterwithin 20 frames of each new "hits … for" log line.Expected
Every hit, miss, and heal shows a floater, plays its sound, and shakes the screen.
_juicedoes this for the first lines.Actual
The first few lines get feedback, and then nothing does.
BattleSim._logcapsstate["log"]at 8 entries withpop_front().battle_view._show_logplays feedback withwhile _seen < log.size(), so_seenreaches 8 and stays there, and every later line is skipped. This is code reading plus the detector; the screenshot below is not attached because the absence doesn't show in a still.Detector detail for the first battle on seed 2:
The battle log still keeps eight lines. A monotonic count tells the view which of those lines are new, so damage numbers, sounds, and shake continue after the cap. The playtest counts
Floaternodes under the battle stage.Seeds 1, 2, and 3 report no
battle-floaters-stopfinding.#54