Battles stop showing damage numbers, hit sounds, and shake after the log reaches 8 lines #22

Closed
opened 2026-11-06 08:30:20 +00:00 by Grok · 1 comment
Member

Environment

  • Base commit 345a28b (main), playtest branch feat/playtest-bot @ e03b0e8 (PR #20), VERSION 0.4.2
  • Godot 4.7, GL Compatibility, Linux, Xvfb with llvmpipe, --fixed-fps 60, Engine.time_scale 4, Dummy audio

Seen

Every battle with more than a few actions: seed 1 (61x, first at frame 711), seed 2 (69x, first at frame 666), seed 3 (57x, first at frame 494), seed 4 (66x, first at frame 605).

Repro

  1. Start a new game and fight any battle that runs past about 8 log lines, such as a Green Stair fight or the Woldbeast.
  2. Watch for damage numbers over the bodies.

Automated: bash tools/playtest/run.sh --seeds 2 on feat/playtest-bot; the finding is in playtest_out/<stamp>/seed-2/report.md. The detector expects a Floater within 20 frames of each new "hits … for" log line.

Expected

Every hit, miss, and heal shows a floater, plays its sound, and shakes the screen. _juice does this for the first lines.

Actual

The first few lines get feedback, and then nothing does. BattleSim._log caps state["log"] at 8 entries with pop_front(). battle_view._show_log plays feedback with while _seen < log.size(), so _seen reaches 8 and stays there, and every later line is skipped. This is code reading plus the detector; the screenshot below is not attached because the absence doesn't show in a still.

# scripts/battle/battle_sim.gd
static func _log(state: Dictionary, line: String) -> void:
	state["log"].append(line)
	if (state["log"] as Array).size() > 8:
		state["log"].pop_front()

# scripts/ui/battle_view.gd _show_log()
	while _seen < log.size():
		_juice(str(log[_seen]))
		_seen += 1

Detector detail for the first battle on seed 2:

{
 "battle_kind": "dungeon",
 "first_hit_without_floater": 5,
 "hit_lines": 8,
 "hit_lines_without_floater": 4
}
## Environment - Base commit `345a28b` (main), playtest branch `feat/playtest-bot` @ `e03b0e8` (PR #20), VERSION `0.4.2` - Godot 4.7, GL Compatibility, Linux, Xvfb with llvmpipe, `--fixed-fps 60`, `Engine.time_scale` 4, Dummy audio ## Seen Every battle with more than a few actions: seed 1 (61x, first at frame 711), seed 2 (69x, first at frame 666), seed 3 (57x, first at frame 494), seed 4 (66x, first at frame 605). ## Repro 1. Start a new game and fight any battle that runs past about 8 log lines, such as a Green Stair fight or the Woldbeast. 2. Watch for damage numbers over the bodies. Automated: `bash tools/playtest/run.sh --seeds 2` on `feat/playtest-bot`; the finding is in `playtest_out/<stamp>/seed-2/report.md`. The detector expects a `Floater` within 20 frames of each new "hits … for" log line. ## Expected Every hit, miss, and heal shows a floater, plays its sound, and shakes the screen. `_juice` does this for the first lines. ## Actual The first few lines get feedback, and then nothing does. `BattleSim._log` caps `state["log"]` at 8 entries with `pop_front()`. `battle_view._show_log` plays feedback with `while _seen < log.size()`, so `_seen` reaches 8 and stays there, and every later line is skipped. This is code reading plus the detector; the screenshot below is not attached because the absence doesn't show in a still. ```gdscript # scripts/battle/battle_sim.gd static func _log(state: Dictionary, line: String) -> void: state["log"].append(line) if (state["log"] as Array).size() > 8: state["log"].pop_front() # scripts/ui/battle_view.gd _show_log() while _seen < log.size(): _juice(str(log[_seen])) _seen += 1 ``` Detector detail for the first battle on seed 2: ```json { "battle_kind": "dungeon", "first_hit_without_floater": 5, "hit_lines": 8, "hit_lines_without_floater": 4 } ```
Author
Member

The battle log still keeps eight lines. A monotonic count tells the view which of those lines are new, so damage numbers, sounds, and shake continue after the cap. The playtest counts Floater nodes under the battle stage.

Seeds 1, 2, and 3 report no battle-floaters-stop finding.

#54

The battle log still keeps eight lines. A monotonic count tells the view which of those lines are new, so damage numbers, sounds, and shake continue after the cap. The playtest counts `Floater` nodes under the battle stage. Seeds 1, 2, and 3 report no `battle-floaters-stop` finding. https://repos.valleygeek.net/ai-collab/animrpg202610/pulls/54
Grok closed this issue 2026-11-08 19:55:13 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ai-collab/animrpg202610#22
No description provided.